Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PW_SID:915024] [v3] Bluetooth: SCO: Add support for 16 bits transparent voice setting #2611

Open
wants to merge 2 commits into
base: workflow
Choose a base branch
from

Conversation

BluezTestBot
Copy link
Owner

The voice setting is used by sco_connect() or sco_conn_defer_accept()
after being set by sco_sock_setsockopt().

The PCM part of the voice setting is used for offload mode through PCM
chipset port.
This commits add support for mSBC 16 bits offloading, i.e. audio data
not transported over HCI.

The BCM4349B1 supports 16 bits transparent data on its I2S port.
If BT_VOICE_TRANSPARENT is used when accepting a SCO connection, this
gives only garbage audio while using BT_VOICE_TRANSPARENT_16BIT gives
correct audio.
This has been tested with connection to iPhone 14 and Samsung S24.

Signed-off-by: Frédéric Danis [email protected]

v1 -> v2: Enhance commit message
v2 -> v3: Enhance commit message

include/net/bluetooth/bluetooth.h | 1 +
net/bluetooth/sco.c | 7 +++++--
2 files changed, 6 insertions(+), 2 deletions(-)

tedd-an and others added 2 commits December 2, 2024 22:51
This patch adds workflow files for ci:

[sync.yml]
 - The workflow file for scheduled work
 - Sync the repo with upstream repo and rebase the workflow branch
 - Review the patches in the patchwork and creates the PR if needed

[ci.yml]
 - The workflow file for CI tasks
 - Run CI tests when PR is created

Signed-off-by: Tedd Ho-Jeong An <[email protected]>
The voice setting is used by sco_connect() or sco_conn_defer_accept()
after being set by sco_sock_setsockopt().

The PCM part of the voice setting is used for offload mode through PCM
chipset port.
This commits add support for mSBC 16 bits offloading, i.e. audio data
not transported over HCI.

The BCM4349B1 supports 16 bits transparent data on its I2S port.
If BT_VOICE_TRANSPARENT is used when accepting a SCO connection, this
gives only garbage audio while using BT_VOICE_TRANSPARENT_16BIT gives
correct audio.
This has been tested with connection to iPhone 14 and Samsung S24.

Signed-off-by: Frédéric Danis <[email protected]>
Copy link

github-actions bot commented Dec 5, 2024

CheckPatch
Desc: Run checkpatch.pl script
Duration: 0.25 seconds
Result: PENDING

Copy link

github-actions bot commented Dec 5, 2024

GitLint
Desc: Run gitlint
Duration: 0.25 seconds
Result: PENDING

Copy link

github-actions bot commented Dec 5, 2024

SubjectPrefix
Desc: Check subject contains "Bluetooth" prefix
Duration: 0.12 seconds
Result: PASS

Copy link

github-actions bot commented Dec 5, 2024

BuildKernel
Desc: Build Kernel for Bluetooth
Duration: 25.68 seconds
Result: PASS

Copy link

github-actions bot commented Dec 5, 2024

CheckAllWarning
Desc: Run linux kernel with all warning enabled
Duration: 27.47 seconds
Result: PASS

Copy link

github-actions bot commented Dec 5, 2024

CheckSparse
Desc: Run sparse tool with linux kernel
Duration: 30.97 seconds
Result: WARNING
Output:

net/bluetooth/sco.c: note: in included file:./include/net/bluetooth/hci_core.h:147:35: warning: array of flexible structures

Copy link

github-actions bot commented Dec 5, 2024

BuildKernel32
Desc: Build 32bit Kernel for Bluetooth
Duration: 24.80 seconds
Result: PASS

Copy link

github-actions bot commented Dec 5, 2024

TestRunnerSetup
Desc: Setup kernel and bluez for test-runner
Duration: 438.49 seconds
Result: PASS

Copy link

github-actions bot commented Dec 5, 2024

TestRunner_l2cap-tester
Desc: Run l2cap-tester with test-runner
Duration: 20.50 seconds
Result: PASS

Copy link

github-actions bot commented Dec 5, 2024

TestRunner_iso-tester
Desc: Run iso-tester with test-runner
Duration: 29.48 seconds
Result: FAIL
Output:

WARNING: possible circular locking dependency detected
Total: 125, Passed: 121 (96.8%), Failed: 0, Not Run: 4

Copy link

github-actions bot commented Dec 5, 2024

TestRunner_bnep-tester
Desc: Run bnep-tester with test-runner
Duration: 4.89 seconds
Result: PASS

Copy link

github-actions bot commented Dec 5, 2024

TestRunner_mgmt-tester
Desc: Run mgmt-tester with test-runner
Duration: 117.29 seconds
Result: PASS

Copy link

github-actions bot commented Dec 5, 2024

TestRunner_rfcomm-tester
Desc: Run rfcomm-tester with test-runner
Duration: 7.70 seconds
Result: PASS

Copy link

github-actions bot commented Dec 5, 2024

TestRunner_sco-tester
Desc: Run sco-tester with test-runner
Duration: 9.46 seconds
Result: PASS

Copy link

github-actions bot commented Dec 5, 2024

TestRunner_ioctl-tester
Desc: Run ioctl-tester with test-runner
Duration: 8.05 seconds
Result: PASS

Copy link

github-actions bot commented Dec 5, 2024

TestRunner_mesh-tester
Desc: Run mesh-tester with test-runner
Duration: 6.06 seconds
Result: PASS

Copy link

github-actions bot commented Dec 5, 2024

TestRunner_smp-tester
Desc: Run smp-tester with test-runner
Duration: 7.03 seconds
Result: PASS

Copy link

github-actions bot commented Dec 5, 2024

TestRunner_userchan-tester
Desc: Run userchan-tester with test-runner
Duration: 5.04 seconds
Result: PASS

Copy link

github-actions bot commented Dec 5, 2024

IncrementalBuild
Desc: Incremental build with the patches in the series
Duration: 0.84 seconds
Result: PENDING

@github-actions github-actions bot force-pushed the workflow branch 3 times, most recently from 9d8c117 to 4db90f9 Compare December 11, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants