-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bleed): Implement wing anti ice system #2
base: bleed
Are you sure you want to change the base?
Changes from all commits
a739f02
91cc942
10a9021
74b2a8c
fee3a0a
164812d
74968ed
971706e
d245ef0
dde198a
f57392f
55845d5
8576936
f493c58
1216343
c23f637
6fe8370
7ec4aec
9ea9661
4a4a819
c13ef8d
f8fb8b8
4595550
ae5267b
f65595f
f1a2d30
0d49f06
9f5220d
95a45cd
9c475f9
b19f983
5f8736f
554221a
722377d
2470021
604439d
33dd8fa
07d7577
7469c27
abdc512
4efbacf
178d9d2
bd0b168
1c6c795
ac657d8
a4546fa
c8de894
b9e5872
0483b2f
3bfd38e
8edea98
c7c7d3c
e1edb7f
43dd820
64810f7
5bf193d
9ce9ff9
07bd95c
16f10e0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -1917,3 +1917,35 @@ In the variables below, {number} should be replaced with one item in the set: { | |||||
- {number} | ||||||
- 1 | ||||||
- 2 | ||||||
|
||||||
- A32NX_PNEU_WING_ANTI_ICE_SYSTEM_ON: | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. By renaming these, we can use the already existing |
||||||
- Indicates wheter the wing anti ice system is on | ||||||
- Bool | ||||||
|
||||||
- A32NX_PNEU_WING_ANTI_ICE_HAS_FAULT: | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
- Indicates wheter the wing anti ice system has a fault | ||||||
- Bool | ||||||
|
||||||
- A32NX_PNEU_LEFT_WING_ANTI_ICE_CONSUMER_PRESSURE: | ||||||
- Pressure in the left wing anti ice pipe | ||||||
- PSI | ||||||
|
||||||
- A32NX_PNEU_RIGHT_WING_ANTI_ICE_CONSUMER_PRESSURE: | ||||||
- Pressure in the right wing anti ice pipe | ||||||
- PSI | ||||||
|
||||||
- A32NX_PNEU_LEFT_WING_ANTI_ICE_CONSUMER_TEMPERATURE: | ||||||
- Temperature in the left wing anti ice pipe | ||||||
- Degree celsius | ||||||
|
||||||
- A32NX_PNEU_RIGHT_WING_ANTI_ICE_CONSUMER_TEMPERATURE: | ||||||
- Temperature in the right wing anti ice pipe | ||||||
- Degree celsius | ||||||
|
||||||
- A32NX_LEFT_WING_ANTI_ICE_VALVE_OPEN: | ||||||
- Indicates whether the left wing anti ice valve is open | ||||||
- Bool | ||||||
|
||||||
- A32NX_RIGHT_WING_ANTI_ICE_VALVE_OPEN: | ||||||
- Indicates whether the right wing anti ice valve is open | ||||||
- Bool | ||||||
Comment on lines
+1929
to
+1951
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It might be smart to use
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if these are required here and I don't want to start ignoring things I don't know about. Is it possible that these were created by some erroneous build command?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are generated by a rust analyzer used in VScode. These files are what made me lose faith in
git
. They don't hold any thing that can ruin the build