Support morphology containers #274
Conversation
mgeplf
force-pushed
the
handle-container-morphs
branch
from
0291bb1 to
76b6c67
Compare
* when the `alternative-morphs` has an `h5` version use the `morphio.Container`, to both load from a directory of from a file
mgeplf
force-pushed
the
handle-container-morphs
branch
from
76b6c67 to
3fb37a7
Compare
| if extension == "h5" and Path(morph_dir).is_file(): | ||
| raise BluepySnapError( | ||
| f"'{morph_dir}' is a morphology container, so a directory does not exist" | ||
| ) |
There was a problem hiding this comment.
If the circuit is using a h5 container instead of a directory, I wonder if we want to raise an error anytime that get_morphology_dir or get_filepath are called, regardless of the extension specified as a parameter?
Probably in the medium/long term those functions could be deprecated, but need to check in what use cases they are needed at the moment.
There was a problem hiding this comment.
You mean if it's the only alternaive-morphology?
There was a problem hiding this comment.
Yeah, but after checking better it's already good as is, because the container file is retrieved only with extension=h5
| with pytest.raises(BluepySnapError): | ||
| test_obj.get_morphology_dir(extension="h5") | ||
|
|
||
| with pytest.raises(BluepySnapError): | ||
| test_obj.get_filepath(node_id, extension="h5") |
There was a problem hiding this comment.
Minor, but the specific reason of BluepySnapError could be checked with match=...
morphio.Container, to both load from a directory or from a file