Skip to content

Commit

Permalink
review
Browse files Browse the repository at this point in the history
  • Loading branch information
edasubert committed Dec 4, 2023
1 parent ed8c065 commit 76be0bd
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
4 changes: 2 additions & 2 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
Changelog
=========

Version v2.2.0~dev0
Version v3.0.0
--------------

Breaking Changes
~~~~~~~~~~~~~~~~
- Edge populations' ``iter_connections`` returns ``CircuitNodeId``s instead of ``int``s
- Edge populations' ``iter_connections`` returns ``CircuitNodeId`` instead of ``int``


Version v2.1.0
Expand Down
8 changes: 5 additions & 3 deletions bluepysnap/edges/edge_population.py
Original file line number Diff line number Diff line change
Expand Up @@ -519,7 +519,7 @@ def _optimal_direction():
break

def _add_circuit_ids(self, its):
"""Generator comprehension adding the CircuitIds to the iterator."""
"""Generator comprehension completing the CircuitNodeId."""
return (
(
CircuitNodeId(self.source.name, source_id),
Expand All @@ -530,7 +530,8 @@ def _add_circuit_ids(self, its):
)

def _add_edge_ids(self, its):
"""Generator comprehension adding the CircuitIds to the iterator."""
"""Generator comprehension completing the CircuitNodeId
and adding the CircuitEdgeIds to the iterator."""
return (
(
CircuitNodeId(self.source.name, source_id),
Expand All @@ -541,7 +542,8 @@ def _add_edge_ids(self, its):
)

def _omit_edge_count(self, its):
"""Generator comprehension adding the CircuitIds to the iterator."""
"""Generator comprehension completing the CircuitNodeId
and removing the edge count."""
return (
(
CircuitNodeId(self.source.name, source_id),
Expand Down

0 comments on commit 76be0bd

Please sign in to comment.