[LLVM] Benchmark related changes #871

iomaganaris · 2022-05-17T17:08:12Z

TODO:

Run benchmark and generate results using the bash script
Figure out git version issue
Refactor BenchmarkResults LLVMBenchmark::run_benchmark()

Please ignore the multiple and odd commits. Those come from rebasing llvm branch to master multiple times

- while working on NMODL + LLVM, we don't worry that much about Python bindings by default - so lets disable them by default

* added NMODL_ENABLE_LLVM option to enable/disable llvm support in nmodl * LLVMHelper.cmake added to help with linking LLVM libraries - clang might need to use libstdc++ or libc++ linking - on BB5, using GCC with LLVM libraries is fine. But using clang results into lots of link error. Adding -stdlib=libstd++ solves the issue - use check_cxx_source_compiles to find out which cxx flag is needed

- added llvm dir under codegen where LLVM code generation work will live - llvm codegen visitor created that can be used as template for initial work - cmake adapted to enable llvm codegen based on CMake option - simple procedure.mod added that can be initial target for testing - new CLI option --llvm that runs LLVM codegen visitor - Enable CXX 14 because new LLVM versions require it

- install llvm via brew - set LLV_DIR variable so that CMake can find llvm-config

- print table with different build options, flags and paths used that can be helpful for debugging - fix git revision date for older git version - update INSTALL.md with correct brew paths for flex and bison

- test/unit/codegen/llvm.cpp added for unit testing LLVM code generation visitor - ./bin/testcodegen binary can be used to launch LLVM codegen specific tests - multiple llvm_map_components_to_libnames removed - update procedure.mod with simple examples for IR generation

* Added LLVM code generation for `ProcedureBlock`. * Added code generation routines for double, integer and boolean variable types. * Added binary and unary operator code generation: - Supported binary operators: +, -, *, /. - Supported unary operators: -. - Assignment (=) is also supported. * Added regex matching unit tests for LLVM code generation. * Fixed Travis CI/builds. fixes #451, fixes #452, fixes #456 Co-authored-by: Pramod Kumbhar <[email protected]>

* LLVM code generation for `FunctionBlock` is now supported. * Terminators in function or procedure blocks are enforced: - Every procedure must have `ret void` instruction. - Every function returns a double, specified by `ret_<function_name>`. * For local symbol table, code generation now uses LLVM's builtin `llvm::ValueSymbolTable`. fixes #454, fixes #469

* Add option to run LLVM optimisation passes - update CLI argument from --llvm to llvm --ir --opt - --ir runs CodegenLLVMVicitor and emits LLVM IR - if --opt is passed, we run basic LLVM optimisation passes - update simple test to check optimisation passes * Add function example in procedure.mod * Add test for LLVM optimisation passes and dead code removal

This patch adds support for function call code generation, particularly: - User-defined procedures and functions can now lowered to LLVM IR. - A framework for external method calls (e.g. sin, exp, etc.) has been created, currently `exp` and `pow` are supported. - Corresponding tests added. fixes #472

LLVM code generation for `IndexedName`s. - Added code generation for initialising arrays in LOCAL blocks (with both integer constants and macros). - Added support for indexing arrays. fixes #467

NMODL AST needs various transformation to generate C++ code or LLVM IR. This PR is begining of AST transformations to simplify code generation backends. * New CodegenLLVMHelperVisitor to perform various AST transformations to simplify code generation for various backends and simulators. * CodegenLLVMHelperVisitor is currently limited to LLVM backend to simplify initial implementation and keep C++ based backends working. * CodegenLLVMHelperVisitor now handles FUNCTIONS and PROCEDURES blocks - Replace LocalListStatement with CodegenVarStatement - Added new AST types for code generation - CodegenVar to represent variable used for code generation - CodegenVarType to represent codegen variable - CodegenVarListStatement to represent list of CodegenVar - CodegenStruct will be used in future to represent struct like NrnThread or Mechanism class See #474

* Added new BinaryOp for += and -= * Added string_to_binaryop function * Added Void node type to represent void return type * Added CodegenAtomicStatement for ion write statements * llvm helper started handling visit_nrn_state_block - NrnStateBlock is being converted into CodegenFunction - for loop body with solution blocks created - voltage and node index initialization code added - read and write ion statements are handled * Some of the functions are now moved into CodegenInfo Co-authored-by: Ioannis Magkanaris <[email protected]>

This commit introduces a functionality to execute functions from MOD file via LLVM jit. For that, there is now: - `JITDriver` class that, given a LLVM IR module, set ups the JIT compiler and is able to look up a function and execute it. - `Runner` class that wraps around JIT driver. It helps to initialise JIT with LLVM IR module only once, and then run multiple functions from it. To execute functions, `nmodl_llvm_runner` executable is used. It takes a single mod file and a specified entry-point function, and runs it via LLVM code generation pipeline and JIT driver. Only functions with double result types are supported at the moment. For example, for MOD file `foo.mod`: ``` FUNCTION one() { one = 1 } FUNCTION bar() { bar = one() + exp(1) } ``` running `nmodl_llvm_runner -f foo.mod -e bar` gives ``` Result: 3.718282 ``` Tests for execution of generated IR have been added as well. fixes #482 Co-authored-by: Pramod Kumbhar <[email protected]>

* Added more bin ops and refactored code - Now, there are code generation functions for all comparison and logical operators. - Code generation functions are now split based on the expression "type" (assignment, arithmetic, comparison, logical). Moreover, the lhs and rhs expression results can be both double and integer. This is important for control flow code generation and for the new AST node CodegenVarType. * Added support for NOT op * Added default type flag to switch between float and double * Added tests for single precision * Renames LLVM test file to codegen_llvm_ir.cpp to follow convention. * NOTE : Tests for new operators will be added when the first control flow node (most likely FOR node) will land. fixes #453

* visit_statement_block of all FUNCTION and PROCEDURE blocks was called resulting in changing LOCAL statement to DOUBLE statement * As statement block doesn't need to be visited for this purpose, rename function to convert_local_statement * Call convert_local_statement only when required i.e. only when codegen function creation time. fixes #491

* Handle CodegenVarType type in JSON printer - As AstNodeType is enum type and node itself, we need to print that explicitly * Indent json visitor jinja template - initially template was not indented as code generated was not looking good - now all generated code is automatically clang-formatted so it's less of a concern. Readability is important. fixes #493

* LLVM Helper visitor now can return a vector of `CodegenFunction`s. * LLVM Helper visitor has been integrated into LLVM visitor: - The type of variables is still double by default, but can also be inferred from `CodegenVarType` node. - Procedure's return type changed to int (so that error codes can be returned in the future). - New visitor functions added: for `CodegenReturn`, `CodegenFunction`, `CodegenVarList` and `CodegenVarType`.

* Added a new code generation function for conditional statements (`if`, `else if`, `else` and their nested variations). * Added tests for the new code generation: - IR unit tests. - Execution tests. * Fixed FP and integer comparison ordering in macros. fixes #468

Added error handling when a non-scope value is looked up. Before, such a lookup would yield a nullptr, therefore leading to a segmentation fault. This PR adds a lookup function that wraps around value symbol lookup, and throws an error with a message if nullptr is returned.

Added support for WHILE statement code generation. Corresponding tests for IR generation and execution were also added. Additional visitor for StatementBlock was added to reduce code duplication. fixes #500

* Moved info related function to codegen_info - Moved get_float_variables, codegen_int_variables, codegen_global_variables, codegen_shadow_variables into CodegenHelper - Move small utility functions from CodegenCVisitor to codeged_utils * Add proper variables to the mech_Instance * Adding LLVMStructBlock * Added test and visitor * Fix llvm codegen tests with x[0-9].*

- Added support for string function arguments. These are converted into global `i8` array values. - Added support for `printf` function call with variable number of arguments. - Refactored function/procedure call argument processing into a separate function. fixes #510

* Move code gen specific InstanceStruct node to codegen.yaml - nmodl.yaml file is more for language constructs - InstanceStruct is specific for code generation and hence move it to codegen.yaml * Update CI scripts * fix cmake-format with v==0.6.13

bbpbuildbot · 2022-12-26T19:32:24Z

Logfiles from GitLab pipeline #92363 (:white_check_mark:) have been uploaded here!

Status and direct links:

bbpbuildbot · 2022-12-26T19:35:24Z

Logfiles from GitLab pipeline #92362 (:white_check_mark:) have been uploaded here!

Status and direct links:

bbpbuildbot · 2022-12-26T19:50:42Z

Logfiles from GitLab pipeline #92366 (:white_check_mark:) have been uploaded here!

Status and direct links:

iomaganaris · 2022-12-26T19:53:39Z

docs/CC2023/README.md

@@ -0,0 +1,74 @@
+
+# MOD2IR: High-Performance Code Generation for a Biophysically Detailed Neuronal Simulation DSL


I think that the attachment of the artifact can be only this file? Or should we provide the docker image as well?

@georgemitenkov @ohm314 @pramodk

iomaganaris · 2022-12-26T19:56:19Z

test/benchmark/gpu_docker/Dockerfile

+RUN pip install Jinja2 PyYAML sympy pytest
+
+# Clone NMODL branch for benchmarking LLVM
+RUN git clone --recursive -b llvm https://github.com/BlueBrain/nmodl.git


I think that this should better be a tag instead of the branch name. Once this is merged to llvm together with any additional changes we should create a tag and update the docker images on DockerHub as well.

@ohm314 @pramodk

iomaganaris · 2022-12-26T19:56:38Z

test/benchmark/cpu_docker/Dockerfile

+RUN pip install Jinja2 PyYAML sympy pytest
+
+# Clone NMODL branch for benchmarking LLVM
+RUN git clone --recursive -b llvm https://github.com/BlueBrain/nmodl.git


Same here, tag instead of branch

bbpbuildbot · 2022-12-26T21:13:39Z

Logfiles from GitLab pipeline #92369 (:white_check_mark:) have been uploaded here!

Status and direct links:

…installation

bbpbuildbot · 2022-12-27T08:06:30Z

Logfiles from GitLab pipeline #92395 (:white_check_mark:) have been uploaded here!

Status and direct links:

docs/CC2023/PAD.md

- Add noalias attribute to the GPU kernels - Avoid adding the wrappers in JIT benchmarks

bbpbuildbot · 2023-01-02T15:33:58Z

Logfiles from GitLab pipeline #92574 (:no_entry:) have been uploaded here!

Status and direct links:

docs/CC2023/README.md

docs/CC2023/PAD.md

bbpbuildbot · 2023-01-02T18:56:56Z

Logfiles from GitLab pipeline #92580 (:white_check_mark:) have been uploaded here!

Status and direct links:

bbpbuildbot · 2023-01-02T19:07:51Z

Logfiles from GitLab pipeline #92582 (:white_check_mark:) have been uploaded here!

Status and direct links:

georgemitenkov

LGTM!

iomaganaris and others added 30 commits June 4, 2021 20:02

Improved output

8fa6225

Fixed compilers

ee91aaa

Changes for Ioannis script

9286bac

Updated script and hh.cpp

a5a259f

Small fix in openmp flags

a02dfa6

Disable python bindings for faster build

a23b1ed

- while working on NMODL + LLVM, we don't worry that much about Python bindings by default - so lets disable them by default

Azure CI fixes for LLVM build and README update

c7c6e40

- install llvm via brew - set LLV_DIR variable so that CMake can find llvm-config

Print build status after cmake configure stage

6cf8320

- print table with different build options, flags and paths used that can be helpful for debugging - fix git revision date for older git version - update INSTALL.md with correct brew paths for flex and bison

Support for IndexedName codegen (#478)

d0fe34d

LLVM code generation for `IndexedName`s. - Added code generation for initialising arrays in LOCAL blocks (with both integer constants and macros). - Added support for indexing arrays. fixes #467

Added support for WHILE statement (#501)

bb82934

Added support for WHILE statement code generation. Corresponding tests for IR generation and execution were also added. Additional visitor for StatementBlock was added to reduce code duplication. fixes #500

Fix issue error: ‘runtime_error’ is not a member of ‘std’ (#512)

fa01b01

iomaganaris requested review from georgemitenkov and pramodk December 26, 2022 19:18

Mention llvm branch in PAD and Dockerfiles

8d06bbf

iomaganaris commented Dec 26, 2022

View reviewed changes

Disable debug symbols in nvptx64 JIT runs due to PTX ISA error

591923a

iomaganaris added 3 commits December 27, 2022 08:44

Added which branch to clone in the readme for the gpu docker runtime …

475a571

…installation

Added some small changes in the PAD text

23eb5e8

Small exmplanation regarding install.sh

896ffd0

georgemitenkov reviewed Dec 27, 2022

View reviewed changes

docs/CC2023/PAD.md Outdated Show resolved Hide resolved

docs/CC2023/PAD.md Show resolved Hide resolved

docs/CC2023/PAD.md Show resolved Hide resolved

georgemitenkov reviewed Dec 27, 2022

View reviewed changes

docs/CC2023/PAD.md Outdated Show resolved Hide resolved

georgemitenkov reviewed Dec 27, 2022

View reviewed changes

docs/CC2023/PAD.md Outdated Show resolved Hide resolved

iomaganaris added 2 commits January 2, 2023 16:12

Fix GPU regression

2b8fc56

- Add noalias attribute to the GPU kernels - Avoid adding the wrappers in JIT benchmarks

Updated readme

70d0dc0

georgemitenkov reviewed Jan 2, 2023

View reviewed changes

docs/CC2023/README.md Outdated Show resolved Hide resolved

docs/CC2023/PAD.md Outdated Show resolved Hide resolved

Updated PAD file according to the submission

f60ac4e

Small fixes in the readme file

e5e010b

georgemitenkov self-requested a review January 2, 2023 19:15

georgemitenkov approved these changes Jan 2, 2023

View reviewed changes

iomaganaris merged commit df581c5 into llvm Jan 2, 2023

iomaganaris deleted the magkanar/benchmark_llvm_gpu_explicit branch January 2, 2023 19:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[LLVM] Benchmark related changes #871

[LLVM] Benchmark related changes #871

iomaganaris commented May 17, 2022 •

edited

Loading

bbpbuildbot commented Dec 26, 2022

bbpbuildbot commented Dec 26, 2022

bbpbuildbot commented Dec 26, 2022

iomaganaris Dec 26, 2022

iomaganaris Dec 26, 2022

iomaganaris Dec 26, 2022

bbpbuildbot commented Dec 26, 2022

bbpbuildbot commented Dec 27, 2022

bbpbuildbot commented Jan 2, 2023

bbpbuildbot commented Jan 2, 2023

bbpbuildbot commented Jan 2, 2023

georgemitenkov left a comment

		@@ -0,0 +1,74 @@

		# MOD2IR: High-Performance Code Generation for a Biophysically Detailed Neuronal Simulation DSL

[LLVM] Benchmark related changes #871

[LLVM] Benchmark related changes #871

Conversation

iomaganaris commented May 17, 2022 • edited Loading

bbpbuildbot commented Dec 26, 2022

bbpbuildbot commented Dec 26, 2022

bbpbuildbot commented Dec 26, 2022

iomaganaris Dec 26, 2022

Choose a reason for hiding this comment

iomaganaris Dec 26, 2022

Choose a reason for hiding this comment

iomaganaris Dec 26, 2022

Choose a reason for hiding this comment

bbpbuildbot commented Dec 26, 2022

bbpbuildbot commented Dec 27, 2022

bbpbuildbot commented Jan 2, 2023

bbpbuildbot commented Jan 2, 2023

bbpbuildbot commented Jan 2, 2023

georgemitenkov left a comment

Choose a reason for hiding this comment

iomaganaris commented May 17, 2022 •

edited

Loading