Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NMODL_GENERATED_SOURCES without Python. #1553

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Fix NMODL_GENERATED_SOURCES without Python. #1553

merged 2 commits into from
Nov 6, 2024

Conversation

1uc
Copy link
Collaborator

@1uc 1uc commented Nov 6, 2024

The logs state that it's regenerating the sources because:

build-integrate/external/nmodl/src/pybind/pyast.cpp

is missing. Which makes sense, because we don't build the NMODL Python binding when it's integrated into NRN.

@1uc 1uc force-pushed the 1uc/fix-cmake-deps branch from 45e82a8 to f9b0f15 Compare November 6, 2024 09:50
@1uc 1uc marked this pull request as ready for review November 6, 2024 10:05
Copy link
Member

@alkino alkino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whouhou

@1uc 1uc merged commit 0186d19 into master Nov 6, 2024
12 checks passed
@1uc 1uc deleted the 1uc/fix-cmake-deps branch November 6, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants