Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support SUFFIX nothing. #1525

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Support SUFFIX nothing. #1525

merged 2 commits into from
Oct 22, 2024

Conversation

1uc
Copy link
Collaborator

@1uc 1uc commented Oct 18, 2024

No description provided.

@1uc 1uc marked this pull request as ready for review October 22, 2024 07:21
@alkino
Copy link
Member

alkino commented Oct 22, 2024

This will fix #1035

@alkino alkino linked an issue Oct 22, 2024 that may be closed by this pull request
Handle SUFFIX nothing #1035
Closed
pramodk
pramodk approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@pramodk pramodk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/codegen/codegen_cpp_visitor.cpp Show resolved Hide resolved
@1uc 1uc merged commit edaa090 into master Oct 22, 2024
12 checks passed
@1uc 1uc deleted the 1uc/nothing branch October 22, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pramodk pramodk pramodk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle SUFFIX nothing
3 participants
@1uc @alkino @pramodk