Add support for diffing against sympy.Indexed instances
#1517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JCGoran
changed the title
sympy.Indexed instancessympy.Indexed instances
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Oct 14, 2024
1uc
approved these changes
Oct 14, 2024
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we have an expression (string) that contains an indexed variable (like
x[0]), we should be able to differentiate w.r.t. it as well.As explained in the updated docstring, the way to do it is to pass a
sympy.Indexedinstance as the independent variable (not to be confused with ansympy.IndexedBaseinstance!).Note that we also need to pass an
sympy.IndexedBaseinto the SymPy list of known symbols (i.e. as one ofvars), otherwise the parser breaks.For reference, we added mod files with indexed vars in #1504.