Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FUNCTION_TABLE with POINT_PROCESS/ARTIFICIAL_CELL. #1513

Merged
merged 6 commits into from
Oct 17, 2024

Conversation

1uc
Copy link
Collaborator

@1uc 1uc commented Oct 11, 2024

There's three bugs that are fixed:

  • make printing the function signature more consistent. This then results in the correct signature for POINT_PROCESSES.
  • while we did register the "HOC" variation, i.e. h.tau2_{mech_name} would work, we didn't register the Python variations meaning s(0.5).{mech_name}.tau2 didn't work.
  • the use_tau2 test had an implicit dependency on a previous test to set the dependency. After the first test ran the last instance of the mechanism went out of scope and the mechanism itself got collected. Leading to invalid memory access.

@1uc 1uc force-pushed the 1uc/fix-function_table branch from 394ab33 to 700a4c0 Compare October 14, 2024 09:43
bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request Oct 14, 2024
@1uc 1uc force-pushed the 1uc/fix-function_table branch from afa781c to f5a9579 Compare October 14, 2024 13:32
bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request Oct 14, 2024
@1uc 1uc marked this pull request as ready for review October 14, 2024 13:52
bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request Oct 17, 2024
@1uc 1uc merged commit 6bcacea into master Oct 17, 2024
12 checks passed
@1uc 1uc deleted the 1uc/fix-function_table branch October 17, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants