Refactor printing setup code in entrypoints. #1502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The entrypoints into the MOD file from NEURON typically require setting up some variable, e.g. `_lmr`, `inst`, `node_data`, `_thread_vars`, etc. The code has roughly two favours: * From fully initialized NEURON, i.e. a Memb_list exists and the model is sorted. All the compute function have this type of entrypoint. * From a `Prop`. Usually this happens when we don't know that the model is sorted, or that initialization has happened. The HOC/Python bindings of FUNCTION/PROCEDUREs use this type of entrypoint.
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Oct 7, 2024
alkino
approved these changes
Oct 8, 2024
JCGoran
reviewed
Oct 8, 2024
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The entrypoints into the MOD file from NEURON typically require setting up some variable, e.g.
_lmr,inst,node_data,_thread_vars, etc.The code has roughly two favours:
From fully initialized NEURON, i.e. a Memb_list exists and the model is sorted. All the compute function have this type of entrypoint.
From a
Prop. Usually this happens when we don't know that the model is sorted, or that initialization has happened. The HOC/Python bindings of FUNCTION/PROCEDUREs use this type of entrypoint.