Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unhelpful comment. #1385

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Remove unhelpful comment. #1385

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions src/codegen/codegen_neuron_cpp_visitor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1127,15 +1127,6 @@
printer->fmt_line("_nrn_thread_table_reg(mech_type, {});", table_thread_function_name());
}

/// Call _nrn_mechanism_register_data_fields() with the correct arguments
/// Geenerated code follows the style underneath
///
/// _nrn_mechanism_register_data_fields(mech_type,
/// _nrn_mechanism_field<double>{"var_name"}, /* float var index 0 */
/// ...
/// );
///
/// TODO: More things to add here
printer->add_line("_nrn_mechanism_register_data_fields(mech_type,");
printer->increase_indent();

Expand Down Expand Up @@ -1281,7 +1272,7 @@

void CodegenNeuronCppVisitor::print_mechanism_range_var_structure(bool print_initializers) {
auto const value_initialize = print_initializers ? "{}" : "";
auto int_type = default_int_data_type();

Check warning on line 1275 in src/codegen/codegen_neuron_cpp_visitor.cpp

View workflow job for this annotation

GitHub Actions / { "flag_warnings": "ON", "glibc_asserts": "ON", "os": "ubuntu-22.04" } 

unused variable ‘int_type’ [-Wunused-variable]

Check warning on line 1275 in src/codegen/codegen_neuron_cpp_visitor.cpp

View workflow job for this annotation

GitHub Actions / { "flag_warnings": "ON", "os": "ubuntu-22.04", "sanitizer": "undefined" } 

unused variable 'int_type' [-Wunused-variable]
printer->add_newline(2);
printer->add_line("/** all mechanism instance variables and global variables */");
printer->fmt_push_block("struct {} ", instance_struct());
Expand Down Expand Up @@ -1580,7 +1571,7 @@
}
const auto& var_name = var->get_name();
auto var_pos = position_of_float_var(var_name);
double var_value = var->get_value() == nullptr ? 0.0 : *var->get_value();

Check warning on line 1574 in src/codegen/codegen_neuron_cpp_visitor.cpp

View workflow job for this annotation

GitHub Actions / { "flag_warnings": "ON", "glibc_asserts": "ON", "os": "ubuntu-22.04" } 

unused variable ‘var_value’ [-Wunused-variable]

Check warning on line 1574 in src/codegen/codegen_neuron_cpp_visitor.cpp

View workflow job for this annotation

GitHub Actions / { "flag_warnings": "ON", "os": "ubuntu-22.04", "sanitizer": "undefined" } 

unused variable 'var_value' [-Wunused-variable]

printer->fmt_line("_lmc.template fpfield<{}>(_iml) = {}; /* {} */",
var_pos,
Expand Down
Loading