Remove pointless check. #1382
Merged
Remove pointless check. #1382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The container is an `unordered_set`, which means we can insert without causing duplication. Hence, we can avoid the find code.
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Jul 31, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1382 +/- ##
==========================================
- Coverage 86.82% 86.82% -0.01%
==========================================
Files 180 180
Lines 13682 13681 -1
==========================================
- Hits 11880 11879 -1
Misses 1802 1802 ☔ View full report in Codecov by Sentry. |
|
Logfiles from GitLab pipeline #224413 (:white_check_mark:) have been uploaded here! Status and direct links: |
alkino
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The container is an
unordered_set, which means we can insert without causingduplication. Hence, we can avoid the find code.