Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove print_namespace_{begin,end}. #1379

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

1uc
Copy link
Collaborator

@1uc 1uc commented Jul 30, 2024

These are new synonyms for print_namespace_{start,stop} and
can therefore be removed.

bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request Jul 30, 2024
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.81%. Comparing base (62268bb) to head (b096f49).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1379      +/-   ##
==========================================
- Coverage   86.82%   86.81%   -0.01%     
==========================================
  Files         180      180              
  Lines       13678    13670       -8     
==========================================
- Hits        11876    11868       -8     
  Misses       1802     1802              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot

This comment has been minimized.

@1uc 1uc marked this pull request as ready for review July 30, 2024 15:26
These are new synonyms for `print_namespace_{start,stop}` and
can therefore be removed.
@1uc 1uc force-pushed the 1uc/remove-print_namespace_begin-end branch from 02101b2 to b096f49 Compare July 31, 2024 14:01
bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request Jul 31, 2024
@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #224524 (:white_check_mark:) have been uploaded here!

Status and direct links:

@1uc 1uc merged commit f18b9d1 into master Aug 5, 2024
24 checks passed
@1uc 1uc deleted the 1uc/remove-print_namespace_begin-end branch August 5, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants