Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify float_variable_name (NEURON version). #1376

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

1uc
Copy link
Collaborator

@1uc 1uc commented Jul 30, 2024

We now understand better what we need, and can clean up the left over dead code from cloning the CoreNEURON method.

We now understand better what we need, and can clean up the left over
dead code from cloning the CoreNEURON method.
bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request Jul 30, 2024
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 86.83%. Comparing base (10788d7) to head (95655cd).

Files Patch % Lines
src/codegen/codegen_neuron_cpp_visitor.cpp 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1376      +/-   ##
==========================================
+ Coverage   86.82%   86.83%   +0.01%     
==========================================
  Files         179      179              
  Lines       13685    13683       -2     
==========================================
  Hits        11882    11882              
+ Misses       1803     1801       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #224195 (:white_check_mark:) have been uploaded here!

Status and direct links:

@1uc 1uc marked this pull request as ready for review July 30, 2024 11:10
@1uc 1uc merged commit 575a724 into master Jul 31, 2024
24 checks passed
@1uc 1uc deleted the 1uc/simplify-float_variable_name branch July 31, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants