Use SymPy solver when using derivimplicit method with NEURON codegen
#1366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Jul 22, 2024
This comment has been minimized.
This comment has been minimized.
- rename `sparse_solver_exists` to `solver_exists` - add `name` argument to `solver_exists` to keep function generic - rename `cnexp` dir to `solve` - add tests for `derivimplicit` method
JCGoran
force-pushed
the
jelic/fix_derivimplicit
branch
from
0b4de51 to
3e552fd
Compare
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Jul 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1366 +/- ##
=======================================
Coverage 86.82% 86.82%
=======================================
Files 179 179
Lines 13684 13685 +1
=======================================
+ Hits 11881 11882 +1
Misses 1803 1803 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
JCGoran
changed the title
derivimplicit methodderivimplicit method with NEURON codegen
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Jul 26, 2024
|
Logfiles from GitLab pipeline #223835 (:white_check_mark:) have been uploaded here! Status and direct links: |
1uc
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One runs into a bunch of compile errors with https://github.com/BlueBrain/nmodlbench/blob/master/benchmark/channels/lib/modlib/cacumm.mod otherwise.
Also added tests.