Implement trivial cases of reading/writing ions. #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can't pass CI until: neuronsimulator/nrn#2712 is available via neuron-nightly wheels. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1152 +/- ##
=======================================
Coverage 88.07% 88.07%
=======================================
Files 175 175
Lines 12526 12614 +88
=======================================
+ Hits 11032 11110 +78
- Misses 1494 1504 +10 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
This implements a trivial case of reading an ion variable `ena` and writing `42.0` to `ina`; along with the functionality required to be able to record `ina`.
|
Logfiles from GitLab pipeline #191961 (:white_check_mark:) have been uploaded here! Status and direct links: |
pramodk
approved these changes
Feb 9, 2024
ohm314
pushed a commit
that referenced
this pull request
May 21, 2024
This implements a trivial case of reading an ion variable `ena` and writing `42.0` to `ina`; along with the functionality required to be able to record `ina`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a trivial case of reading an ion variable
enaand writing42.0toina; along with the functionality required to be able to recordina.