Avoid toggling codegen. #1116
Merged
Avoid toggling codegen. #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1116 +/- ##
==========================================
+ Coverage 88.24% 88.26% +0.02%
==========================================
Files 175 175
Lines 12960 12952 -8
==========================================
- Hits 11436 11432 -4
+ Misses 1524 1520 -4 ☔ View full report in Codecov by Sentry. |
iomaganaris
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The strategy for toggling on
codegenseems to be to do it in the top-level function. These aren't or don't contain any code that recurses down the tree. Togglingcodegenhere seems either pointless or harmful. Hence, the proposal to not togglecodegenhere.