Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semantic: check there is at most one DERIVATIVE block #1098

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

alkino
Copy link
Member

@alkino alkino commented Nov 21, 2023

This is not forbidden to have more, but due to a bug this fail in nrn.

This is not forbidden to have more, but due to a bug this fail in nrn.
@alkino alkino force-pushed the cornu/at_most_one_derivative_block branch from 5ed9ab5 to 2dea9aa Compare November 21, 2023 10:47
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f57d0d7) 88.68% compared to head (2438b34) 88.67%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1098      +/-   ##
==========================================
- Coverage   88.68%   88.67%   -0.01%     
==========================================
  Files         170      170              
  Lines       12548    12540       -8     
==========================================
- Hits        11128    11120       -8     
  Misses       1420     1420              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot

This comment has been minimized.

Copy link
Contributor

@pramodk pramodk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

> fatal: No names found, cannot describe anything.
@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #172206 (:white_check_mark:) have been uploaded here!

Status and direct links:

@alkino alkino merged commit 6c89dc6 into master Nov 22, 2023
18 checks passed
@alkino alkino deleted the cornu/at_most_one_derivative_block branch November 22, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants