Skip to content
This repository has been archived by the owner on Jan 28, 2022. It is now read-only.

Disable compression minimapp by default #84

Merged
merged 1 commit into from
Jul 20, 2018
Merged

Conversation

pramodk
Copy link
Contributor

@pramodk pramodk commented Jul 20, 2018

To avoid compilation issues (which should be solved), I am disabling compression :

[ 46%] Building CXX object neuromapp/keyvalue/CMakeFiles/MPI_Exec_kv.dir/mpiexec.cpp.o
In file included from /Users/kumbhar/Downloads/neuromapp/test/compression/block_reading.cpp:16:
/Users/kumbhar/Downloads/neuromapp/neuromapp/compression/allocator.h:105:13: error: unknown type name 'constexpr'
            constexpr static char policy_name[] = "cstandard";
            ^
/Users/kumbhar/Downloads/neuromapp/neuromapp/compression/allocator.h:105:23: error: expected member name or ';' after declaration specifiers
            constexpr static char policy_name[] = "cstandard";
            ~~~~~~~~~ ^
/Users/kumbhar/Downloads/neuromapp/neuromapp/compression/allocator.h:49:88: error: use of enumeration in a nested name specifier is a C++11 extension
      [-Werror,-Wc++11-extensions]
                    throw cpu_memory_allocation("negative size, cpu cstandard policy", lengine_error::NEUROMAPP_BAD_ARG);
                                                                                       ^
/Users/kumbhar/Downloads/neuromapp/neuromapp/compression/allocator.h:51:84: error: use of enumeration in a nested name specifier is a C++11 extension
      [-Werror,-Wc++11-extensions]
                    throw cpu_memory_allocation("null size, cpu cstandard policy", lengine_error::NEUROMAPP_BAD_ARG);
                                                                                   ^
/Users/kumbhar/Downloads/neuromapp/neuromapp/compression/allocator.h:201:13: error: unknown type name 'constexpr'
            constexpr static char policy_name[] = "align";
            ^
/Users/kumbhar/Downloads/neuromapp/neuromapp/compression/allocator.h:201:23: error: expected member name or ';' after declaration specifiers

@pramodk pramodk requested a review from fouriaux July 20, 2018 10:13
@pramodk pramodk force-pushed the disable_compression branch from 7bd3068 to 4057222 Compare July 20, 2018 10:56
Copy link
Contributor

@fouriaux fouriaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a ticket open to fix this issue before merging ?

@pramodk
Copy link
Contributor Author

pramodk commented Jul 20, 2018

Ok, seems like clang specific problem.

@pramodk
Copy link
Contributor Author

pramodk commented Jul 20, 2018

@fouriaux : done in #85. For now I am just updating README.
By the way, are you invisible? :)

@pramodk pramodk merged commit 70d6d24 into master Jul 20, 2018
@pramodk pramodk deleted the disable_compression branch July 20, 2018 11:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants