Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove inexistent features from units.json #398

Merged
merged 1 commit into from
May 27, 2024

Conversation

AurelienJaquier
Copy link
Collaborator

Description

Those features were originally in the 'Requested eFeatures' part of the documentation and were wrongly added to the units.json. This corrects it and removes those nonexistent features.

Checklist:

  • Unit tests are added to cover the changes (skip if not applicable).
  • The changes are mentioned in the documentation (skip if not applicable).
  • CHANGELOG file is updated (skip if not applicable).

@AurelienJaquier AurelienJaquier self-assigned this May 27, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.84%. Comparing base (2cddd26) to head (b2ec8fe).
Report is 20 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #398      +/-   ##
==========================================
+ Coverage   91.73%   91.84%   +0.11%     
==========================================
  Files          36       37       +1     
  Lines        6278     7113     +835     
  Branches     2033     2282     +249     
==========================================
+ Hits         5759     6533     +774     
- Misses        266      301      +35     
- Partials      253      279      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AurelienJaquier AurelienJaquier merged commit 7a69d06 into BlueBrain:master May 27, 2024
20 checks passed
@AurelienJaquier AurelienJaquier deleted the fix-units branch May 27, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants