-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring #388
Refactoring #388
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #388 +/- ##
==========================================
+ Coverage 91.73% 91.80% +0.07%
==========================================
Files 36 37 +1
Lines 6278 6956 +678
Branches 2033 2241 +208
==========================================
+ Hits 5759 6386 +627
- Misses 266 298 +32
- Partials 253 272 +19 ☔ View full report in Codecov by Sentry. |
@@ -165,7 +176,7 @@ time from stimulus start to last spike | |||
|
|||
number of spikes in the trace, including outside of stimulus interval | |||
|
|||
- **Required features**: LibV1:peak_indices |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Brilliant
Description
Put cpp features in 3 main categories: SpikeEvent, SpikeShape and Subthreshold. a 4th category, BasicFeatures, has also been created and contains interpolate, voltage, time and current.
Checklist: