Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring #388

Merged
merged 7 commits into from
May 2, 2024
Merged

Conversation

AurelienJaquier
Copy link
Collaborator

Description

Put cpp features in 3 main categories: SpikeEvent, SpikeShape and Subthreshold. a 4th category, BasicFeatures, has also been created and contains interpolate, voltage, time and current.

Checklist:

  • Unit tests are added to cover the changes (skip if not applicable).
  • The changes are mentioned in the documentation (skip if not applicable).
  • CHANGELOG file is updated (skip if not applicable).

@AurelienJaquier AurelienJaquier self-assigned this May 2, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 2, 2024

Codecov Report

Attention: Patch coverage is 86.91450% with 352 lines in your changes are missing coverage. Please review.

Project coverage is 91.80%. Comparing base (2cddd26) to head (5d2b13c).
Report is 12 commits behind head on master.

Files Patch % Lines
efel/cppcore/SpikeShape.cpp 85.26% 68 Missing and 120 partials ⚠️
efel/cppcore/SpikeEvent.cpp 85.41% 42 Missing and 62 partials ⚠️
efel/cppcore/Subthreshold.cpp 88.57% 11 Missing and 49 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #388      +/-   ##
==========================================
+ Coverage   91.73%   91.80%   +0.07%     
==========================================
  Files          36       37       +1     
  Lines        6278     6956     +678     
  Branches     2033     2241     +208     
==========================================
+ Hits         5759     6386     +627     
- Misses        266      298      +32     
- Partials      253      272      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AurelienJaquier AurelienJaquier requested a review from anilbey May 2, 2024 13:00
@@ -165,7 +176,7 @@ time from stimulus start to last spike

number of spikes in the trace, including outside of stimulus interval

- **Required features**: LibV1:peak_indices
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Copy link
Contributor

@anilbey anilbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Brilliant

@AurelienJaquier AurelienJaquier merged commit cc4edb9 into BlueBrain:master May 2, 2024
20 checks passed
@AurelienJaquier AurelienJaquier deleted the refactoring branch May 2, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants