Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small fix in documentation #378

Merged
merged 12 commits into from
Apr 25, 2024
Merged

Conversation

AurelienJaquier
Copy link
Collaborator

Description

python efeature was not linked for a particular feature in the documentation

Checklist:

  • [skip ] Unit tests are added to cover the changes (skip if not applicable).
  • [skip ] The changes are mentioned in the documentation (skip if not applicable).
  • [ skip] CHANGELOG file is updated (skip if not applicable).

@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.73%. Comparing base (171f25c) to head (708defe).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #378      +/-   ##
==========================================
- Coverage   91.86%   91.73%   -0.14%     
==========================================
  Files          36       36              
  Lines        6258     6278      +20     
  Branches     2024     2030       +6     
==========================================
+ Hits         5749     5759      +10     
- Misses        258      266       +8     
- Partials      251      253       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@darshanmandge
Copy link
Contributor

Could you also update the examples documentation page with the new examples in repository ?

@AurelienJaquier
Copy link
Collaborator Author

Could you also update the examples documentation page with the new examples in repository ?

done in latest commits

@AurelienJaquier
Copy link
Collaborator Author

For the wheels tests, macos-latest has recently been updated to version 14, and our workflow can't find any python when using this version, so I reverted to what used to be macos-latest before the update: macos-12.

@AurelienJaquier AurelienJaquier requested a review from anilbey April 25, 2024 07:34
Copy link
Contributor

@anilbey anilbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow great, thanks

@AurelienJaquier AurelienJaquier merged commit b8a1a6a into BlueBrain:master Apr 25, 2024
20 checks passed
@AurelienJaquier AurelienJaquier deleted the doc-fix branch April 25, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants