Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISI_CV: return None when None #373

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

AurelienJaquier
Copy link
Collaborator

Description

Please include a summary of the change.
By default the change will increment the patch version.
To increment major or minor changes add #major or #minor to the PR description.

Checklist:

  • Unit tests are added to cover the changes (skip if not applicable).
  • The changes are mentioned in the documentation (skip if not applicable).
  • CHANGELOG file is updated (skip if not applicable).

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 91.86%. Comparing base (bffef33) to head (171f25c).
Report is 3 commits behind head on master.

Files Patch % Lines
efel/pyfeatures/isi.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #373       +/-   ##
===========================================
+ Coverage   68.49%   91.86%   +23.37%     
===========================================
  Files          36       36               
  Lines        6446     6258      -188     
  Branches     2087     2024       -63     
===========================================
+ Hits         4415     5749     +1334     
+ Misses        275      258       -17     
+ Partials     1756      251     -1505     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@darshanmandge darshanmandge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works with an example which had error similar to that in #372

@AurelienJaquier AurelienJaquier merged commit 8bd317f into BlueBrain:master Mar 18, 2024
20 checks passed
@AurelienJaquier AurelienJaquier deleted the fix-isi-cv branch March 18, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants