Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type stub for cppcore #358

Merged
merged 8 commits into from
Jan 16, 2024
Merged

Add type stub for cppcore #358

merged 8 commits into from
Jan 16, 2024

Conversation

anilbey
Copy link
Contributor

@anilbey anilbey commented Jan 15, 2024

Pull Request Template

Description

  • Allows the argument and return types of the functions in cppcore to be understood by Python by providing the type stub file. Stub file is added to the package to allow downstream applications e.g. bluepyefe to recognise cppcore types.

  • Adds mypy type checker to tox and github actions to check for type errors

  • Fixes 2 small type errors

Checklist:

  • Unit tests are added to cover the changes.
  • The changes are mentioned in the documentation.
  • CHANGELOG.md is updated (skip if the change is not important for the changelog).

@anilbey anilbey self-assigned this Jan 15, 2024
@anilbey anilbey changed the title Add type annotations Add type annotations for cppcore Jan 16, 2024
@anilbey anilbey changed the title Add type annotations for cppcore Add type stub for cppcore Jan 16, 2024
@anilbey anilbey marked this pull request as ready for review January 16, 2024 11:15
@anilbey anilbey merged commit 160db25 into master Jan 16, 2024
9 checks passed
@anilbey anilbey deleted the typing branch January 16, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants