Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address 2 compiler warnings #357

Merged
merged 3 commits into from
Jan 11, 2024
Merged

Address 2 compiler warnings #357

merged 3 commits into from
Jan 11, 2024

Conversation

anilbey
Copy link
Contributor

@anilbey anilbey commented Jan 11, 2024

Description

Addresses 2 cpp compilation warnings.

@anilbey anilbey changed the title Cpp warnings Address 2 compiler warnings Jan 11, 2024
Copy link
Collaborator

@ilkilic ilkilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (7292382) 65.95% compared to head (f1f96f2) 66.00%.

Files Patch % Lines
efel/cppcore/LibV5.cpp 0.00% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #357      +/-   ##
==========================================
+ Coverage   65.95%   66.00%   +0.05%     
==========================================
  Files          33       33              
  Lines        6445     6440       -5     
  Branches     2284     2279       -5     
==========================================
  Hits         4251     4251              
  Misses        265      265              
+ Partials     1929     1924       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anilbey anilbey merged commit 328153e into master Jan 11, 2024
8 checks passed
@anilbey anilbey deleted the cpp-warnings branch January 11, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants