Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AHP plot timing in L5TTPC2.ipynb #356

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Fix AHP plot timing in L5TTPC2.ipynb #356

merged 1 commit into from
Jan 11, 2024

Conversation

ilkilic
Copy link
Collaborator

@ilkilic ilkilic commented Jan 11, 2024

Description

Correct timing in AHP_depth_abs plot in example notebook L5TTPC2 of nmc-portal. Adjust plot to display AHP_depth_abs at peak_times + time to AHP from peak, ensuring accurate representation of data.

Checklist:

  • Unit tests are added to cover the changes.
  • The changes are mentioned in the documentation.
  • CHANGELOG.md is updated (skip if the change is not important for the changelog).

@ilkilic ilkilic self-assigned this Jan 11, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3ffb816) 65.95% compared to head (1efafc6) 65.95%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #356   +/-   ##
=======================================
  Coverage   65.95%   65.95%           
=======================================
  Files          33       33           
  Lines        6445     6445           
  Branches     2284     2284           
=======================================
  Hits         4251     4251           
  Misses        265      265           
  Partials     1929     1929           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@AurelienJaquier AurelienJaquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you! I appreciate that you also cleaned up the messy outputs with warnings

Copy link
Contributor

@darshanmandge darshanmandge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ilkilic !

@ilkilic ilkilic merged commit 7292382 into master Jan 11, 2024
8 checks passed
@ilkilic ilkilic deleted the fix-ahp-plot-timing branch January 11, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants