New feature: phaseslope_max #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 29, 2023 10:20
added 5 commits
January 17, 2024 10:28
…validation-features Conflicts: efel/pyfeatures/pyfeatures.py
added 3 commits
January 17, 2024 10:51
ilkilic
reviewed
Jan 17, 2024
efel/pyfeatures/pyfeatures.py
Outdated
| phaseslope = diff(voltage) / diff(time) | ||
| phaseslope_max = max(phaseslope) | ||
|
|
||
| if phaseslope_max.size == 0: |
There was a problem hiding this comment.
I think this check won't work as intended because phaseslope_max is a scalar. I think this check should be performed before computing the max
There was a problem hiding this comment.
Fixed with a try/except in latest commit
There was a problem hiding this comment.
Thanks! looks great! nice that you switched to numpy.max ;)
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #352 +/- ##
==========================================
+ Coverage 66.04% 66.07% +0.03%
==========================================
Files 33 33
Lines 6446 6459 +13
Branches 2279 2279
==========================================
+ Hits 4257 4268 +11
- Misses 265 267 +2
Partials 1924 1924 ☔ View full report in Codecov by Sentry. |
ilkilic
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
New feature: phaseslope_max. To compute the maximum of the (positive) derivative of voltage. Note that this is sensible to interpolation timestep.
Checklist: