Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a pull request template #342

Merged
merged 3 commits into from
Jan 5, 2024
Merged

Conversation

anilbey
Copy link
Contributor

@anilbey anilbey commented Jan 5, 2024

Adds the PR template below that reminds us the checklist items to be checked before merging (e.g. add test, docs, changelog).

# Pull Request Template

## Description

Please include a summary of the change.
By default the change will increment the patch version, to increment major or minor changes add #major or #minor to the PR description.


## Checklist:
- [ ] Unit tests are added to cover the changes.
- [ ] The changes are mentioned in the documentation.
- [ ] CHANGELOG.md is updated (skip if the change is not important for the changelog).

Copy link
Contributor

@darshanmandge darshanmandge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! If you want, you can also add an issue template

@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b7c2f60) 56.47% compared to head (225d13f) 56.47%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #342   +/-   ##
=======================================
  Coverage   56.47%   56.47%           
=======================================
  Files          30       30           
  Lines        7727     7727           
  Branches     3274     3274           
=======================================
  Hits         4364     4364           
  Misses        843      843           
  Partials     2520     2520           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anilbey anilbey merged commit 8185fd8 into BlueBrain:master Jan 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants