Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update outdated example notebooks #339

Merged
merged 8 commits into from
Dec 19, 2023
Merged

Update outdated example notebooks #339

merged 8 commits into from
Dec 19, 2023

Conversation

ilkilic
Copy link
Collaborator

@ilkilic ilkilic commented Dec 18, 2023

No description provided.

@ilkilic ilkilic self-assigned this Dec 18, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1d898c8) 56.47% compared to head (18e389b) 56.47%.

❗ Current head 18e389b differs from pull request most recent head 88c7f0b. Consider uploading reports for the commit 88c7f0b to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #339   +/-   ##
=======================================
  Coverage   56.47%   56.47%           
=======================================
  Files          30       30           
  Lines        7727     7727           
  Branches     3274     3274           
=======================================
  Hits         4364     4364           
  Misses        843      843           
  Partials     2520     2520           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ilkilic ilkilic changed the title Update outdated examples Update outdated example notebooks Dec 19, 2023
@ilkilic ilkilic requested a review from anilbey December 19, 2023 10:24
Copy link
Contributor

@anilbey anilbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow fantastic, thanks! Now we can be sure that all examples are up-to-date.

@ilkilic ilkilic merged commit b7c2f60 into master Dec 19, 2023
7 checks passed
@ilkilic ilkilic deleted the update-example branch December 19, 2023 12:47
@anilbey
Copy link
Contributor

anilbey commented Dec 19, 2023

Some notebooks were not even touched since python2.7.

-   "pygments_lexer": "ipython2",
-   "version": "2.7.11"
+   "pygments_lexer": "ipython3",
+   "version": "3.11.4"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants