Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add EfelExceptions.h to setup #333

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

AurelienJaquier
Copy link
Collaborator

EfelExceptions.h file was added in PR #329 but it was not added to the headers list in setup. Because of this, it was not included in the tarball, and users would not be able to install efel without wheels.

Fixes Issue #332

@AurelienJaquier AurelienJaquier self-assigned this Nov 22, 2023
Copy link
Collaborator

@ilkilic ilkilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and I confirm it works now. Great catch!

@AurelienJaquier AurelienJaquier merged commit 09ccf6d into BlueBrain:master Nov 22, 2023
6 checks passed
@AurelienJaquier AurelienJaquier deleted the setup-fix branch November 22, 2023 09:34
@anilbey
Copy link
Contributor

anilbey commented Nov 29, 2023

Oh, great, thanks for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants