bring efel to c++17 standard #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efel/cppcore/LibV1.cpp
Outdated
| GErrorStr += "Could not find the decay.\n"; | ||
| return -1; | ||
| } | ||
| i_start++; |
There was a problem hiding this comment.
why the indentation here?
There was a problem hiding this comment.
I think I got confused with 4spaces vs 2 spaces indentation. Let me take it back
efel/cppcore/LibV1.cpp
Outdated
| v.begin(), find_if(v.begin() + indices[i], v.begin() + indices[i + 1], | ||
| bind2nd(greater_equal<double>(), threshold))); | ||
| auto onset_index = std::distance( | ||
| v.begin(), std::find_if(v.begin() + indices[i], v.begin() + indices[i + 1], |
There was a problem hiding this comment.
why use std:: here? You did not use it for the other changes
There was a problem hiding this comment.
Done in the next commit. The usage is now consistent within LibV1
efel/cppcore/LibV5.cpp
Outdated
| std::bind2nd(std::less_equal<double>(), minimum_voltage))); | ||
| // get start index | ||
| const size_t decayStartIdx = | ||
| std::distance(voltage.begin(), |
There was a problem hiding this comment.
there are some more std::distance here
There was a problem hiding this comment.
The previous commit was for LibV1, the next ones repeat it for LibV5 for std::distance and std::find_if.
AurelienJaquier
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: