Skip to content

Commit

Permalink
fix docs, units and tests for latest new features
Browse files Browse the repository at this point in the history
  • Loading branch information
Jaquier Aurélien Tristan committed Oct 26, 2023
1 parent 7f55032 commit f52f468
Show file tree
Hide file tree
Showing 4 changed files with 39 additions and 23 deletions.
30 changes: 15 additions & 15 deletions docs/source/eFeatures.rst
Original file line number Diff line number Diff line change
Expand Up @@ -555,7 +555,7 @@ The burst detection can be fine-tuned by changing the setting strict_burst_facto
))

`LibV5`_ : postburst_slow_ahp_values
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

The slow AHP voltage after the end of a burst.

Expand Down Expand Up @@ -585,7 +585,7 @@ The burst detection can be fine-tuned by changing the setting strict_burst_facto
postburst_slow_ahp.append(numpy.min(v[i_start:]))

`LibV5`_ : time_to_interburst_min
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

The time between the last spike of a burst and the minimum between that spike and the next.

Expand All @@ -607,7 +607,7 @@ The burst detection can be fine-tuned by changing the setting strict_burst_facto
]

`LibV5`_ : time_to_postburst_slow_ahp
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

The time between the last spike of a burst and the slow ahp afterwards.

Expand All @@ -627,7 +627,7 @@ The burst detection can be fine-tuned by changing the setting strict_burst_facto
time_to_postburst_slow_ahp_py = t[postburst_slow_ahp_indices] - peak_time[burst_end_indices]

`LibV5`_ : postburst_fast_ahp_values
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

The fast AHP voltage after the end of a burst.

Expand Down Expand Up @@ -663,7 +663,7 @@ The burst detection can be fine-tuned by changing the setting strict_burst_facto
return postburst_fahp

`LibV5`_ : postburst_adp_peak_values
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

The small ADP peak after the fast AHP after the end of a burst.

Expand All @@ -690,7 +690,7 @@ The burst detection can be fine-tuned by changing the setting strict_burst_facto
return adp_peak_values

`LibV5`_ : time_to_postburst_fast_ahp
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Time to the fast AHP after the end of a burst.

Expand All @@ -707,7 +707,7 @@ The burst detection can be fine-tuned by changing the setting strict_burst_facto
[t[fahpi] - peak_time[burst_endi[i]] for i, fahpi in enumerate(postburst_fahpi)]

`LibV5`_ : time_to_postburst_adp_peak
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Time to the small ADP peak after the fast AHP after the end of a burst.

Expand Down Expand Up @@ -738,7 +738,7 @@ The burst detection can be fine-tuned by changing the setting strict_burst_facto


`LibV5`_ : interburst_15percent_values
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Voltage value after 15% of the interburst duration after the fast AHP.

Expand All @@ -761,7 +761,7 @@ The burst detection can be fine-tuned by changing the setting strict_burst_facto
interburst_15percent_values.append(v[index_at_15percent])

`LibV5`_ : interburst_20percent_values
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Voltage value after 20% of the interburst duration after the fast AHP.

Expand All @@ -784,7 +784,7 @@ The burst detection can be fine-tuned by changing the setting strict_burst_facto
interburst_20percent_values.append(v[index_at_20percent])

`LibV5`_ : interburst_25percent_values
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Voltage value after 25% of the interburst duration after the fast AHP.

Expand All @@ -807,7 +807,7 @@ The burst detection can be fine-tuned by changing the setting strict_burst_facto
interburst_25percent_values.append(v[index_at_25percent])

`LibV5`_ : interburst_30percent_values
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Voltage value after 30% of the interburst duration after the fast AHP.

Expand All @@ -830,7 +830,7 @@ The burst detection can be fine-tuned by changing the setting strict_burst_facto
interburst_30percent_values.append(v[index_at_30percent])

`LibV5`_ : interburst_40percent_values
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Voltage value after 40% of the interburst duration after the fast AHP.

Expand All @@ -853,7 +853,7 @@ The burst detection can be fine-tuned by changing the setting strict_burst_facto
interburst_40percent_values.append(v[index_at_40percent])

`LibV5`_ : interburst_60percent_values
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Voltage value after 60% of the interburst duration after the fast AHP.

Expand All @@ -876,7 +876,7 @@ The burst detection can be fine-tuned by changing the setting strict_burst_facto
interburst_60percent_values.append(v[index_at_60percent])

`LibV5`_ : interburst_duration
~~~~~~~~~~~~~~~~~~~~~~~~~~~
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Duration between the last spike of each burst and the next spike.

Expand All @@ -897,7 +897,7 @@ The burst detection can be fine-tuned by changing the setting strict_burst_facto
]

`LibV1`_ : single_burst_ratio
~~~~~~~~~~~~~~~~~~~~~~~~~~
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Length of the second isi over the median of the rest of the isis.
The first isi is not taken into account, because it could bias the feature.
Expand Down
15 changes: 14 additions & 1 deletion efel/units/units.json
Original file line number Diff line number Diff line change
Expand Up @@ -144,5 +144,18 @@
"initburst_sahp_ssse": "mV",
"initburst_sahp_vb": "mV",
"depol_block_bool": "constant",
"impedance": "Hz"
"impedance": "Hz",
"postburst_slow_ahp_values": "mV",
"time_to_postburst_slow_ahp": "ms",
"postburst_fast_ahp_values": "mV",
"postburst_adp_peak_values": "mV",
"time_to_postburst_fast_ahp": "ms",
"time_to_postburst_adp_peak": "ms",
"interburst_15percent_values": "mV",
"interburst_20percent_values": "mV",
"interburst_25percent_values": "mV",
"interburst_30percent_values": "mV",
"interburst_40percent_values": "mV",
"interburst_60percent_values": "mV",
"interburst_duration": "ms"
}
5 changes: 4 additions & 1 deletion tests/test_basic.py
Original file line number Diff line number Diff line change
Expand Up @@ -3924,7 +3924,10 @@ def test_time_to_postburst_slow_ahp():
"time_to_postburst_slow_ahp"
]

if peak_time is None or burst_end_indices is None:
if (
postburst_slow_ahp_indices is None or len(postburst_slow_ahp_indices) == 0
or burst_end_indices is None or len(burst_end_indices) == 0
):
time_to_postburst_slow_ahp_py = None
else:
time_to_postburst_slow_ahp_py = interp_time[
Expand Down
12 changes: 6 additions & 6 deletions tests/testdata/allfeatures/expectedresults.json
Original file line number Diff line number Diff line change
Expand Up @@ -461,17 +461,17 @@
-2.3944223175083863
],
"interburst_15percent_indices": null,
"interburst_15percent_values": null,
"interburst_15percent_values": [],
"interburst_20percent_indices": null,
"interburst_20percent_values": null,
"interburst_20percent_values": [],
"interburst_25percent_indices": null,
"interburst_25percent_values": null,
"interburst_25percent_values": [],
"interburst_30percent_indices": null,
"interburst_30percent_values": null,
"interburst_30percent_values": [],
"interburst_40percent_indices": null,
"interburst_40percent_values": null,
"interburst_40percent_values": [],
"interburst_60percent_indices": null,
"interburst_60percent_values": null,
"interburst_60percent_values": [],
"interburst_duration": null,
"interburst_min_indices": [],
"interburst_min_values": [],
Expand Down

0 comments on commit f52f468

Please sign in to comment.