fix edge case in phaseslope_max

BlueBrain · Jan 17, 2024 · ebfeae7 · ebfeae7
1 parent 203a033
commit ebfeae7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/docs/source/eFeatures.rst b/docs/source/eFeatures.rst
@@ -1936,7 +1936,8 @@ Attention, this feature is sensitive to interpolation timestep.
 - **Units**: V/s
 - **Pseudocode**: ::
 
-    phaseslope_max= max(numpy.diff(voltage) / numpy.diff(time))
+    phaseslope = numpy.diff(voltage) / numpy.diff(time)
+    phaseslope_max = numpy.array([numpy.max(phaseslope)])
 
 
 

diff --git a/efel/pyfeatures/pyfeatures.py b/efel/pyfeatures/pyfeatures.py
@@ -435,11 +435,10 @@ def phaseslope_max():
     from numpy import diff
 
     phaseslope = diff(voltage) / diff(time)
-    phaseslope_max = max(phaseslope)
-
-    if phaseslope_max.size == 0:
+    try:
+        return numpy.array([numpy.max(phaseslope)])
+    except ValueError:
         return None
-    return numpy.array([phaseslope_max])
 
 
 def get_cpp_feature(featureName, raise_warnings=None):