Fix efel logging on windows for caching test

BlueBrain · Oct 18, 2023 · 3f5e15a · 3f5e15a
1 parent 8bfe7a4
commit 3f5e15a
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/efel/cppcore/eFELLogger.h b/efel/cppcore/eFELLogger.h
@@ -23,6 +23,7 @@
 #include <iostream>
 #include <fstream>
 #include <vector>
+#include <string>
 
 class eFELLogger
 {
@@ -37,6 +38,13 @@ class eFELLogger
     }
   }
 
+  ~eFELLogger() 
+  {
+    if (logfile.is_open()) {
+        logfile.close();
+    }
+  }
+
   template<typename T>
   eFELLogger &operator<<(const std::vector<T> &v){
     if(logging){

diff --git a/tests/test_cppcore.py b/tests/test_cppcore.py
@@ -200,6 +200,9 @@ def test_caching(self, feature_name):
             efel.cppcore.getFeature(feature_name, feature_values)
             with (Path(tempdir) / 'fllog.txt').open() as fd:
                 contents = fd.read()
+            # re-call efel's Initialize with current dir to remove pointer to tempdir.
+            # this pointer was preventing the deletion of tempdir on windows.
+            efel.cppcore.Initialize(efel.getDependencyFileLocation(), '.')
         assert f"Calculated feature {feature_name}" in contents
         assert f"Reusing computed value of {feature_name}" in contents
         # make sure Calculated feature text occurs once