Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upper case ASC, SWC compatible hoc template #269

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

AurelienJaquier
Copy link
Collaborator

No description provided.

Copy link

@darshanmandge darshanmandge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AurelienJaquier !
For future reference, this change was necessary to allow uppercase morphology extension names used with the hoc templates. The change was also added to bluepyemodel with this PR where it worked with one of the morphologies with both "ASC" and "SWC" as extensions.

@AurelienJaquier AurelienJaquier merged commit 3d21d31 into BlueBrain:master Apr 12, 2024
4 checks passed
@AurelienJaquier AurelienJaquier deleted the ASC-hoc branch April 12, 2024 07:20
@arnaudon
Copy link
Contributor

Hello, I'm a bit late here, but we usually rename the extension with morphology release, before running any opt, etc...

@darshanmandge
Copy link

Ok. There were some morphologies which had uppercase extensions for the some brain regions. When the emodels were exported using bluepyemodel for OBP emodels, the template failed to recognise those morphologies. This is a precaution when external users try to use such morphologies for the exported emodels with this template.

@arnaudon
Copy link
Contributor

was this because you gave the name of the morph with .ASC, but the morph filename is with .asc ?

@darshanmandge
Copy link

I gave a morph .ASC and the morph name was also .ASC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants