Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: repetitions support for ScalaNWBReader #194

Merged
merged 6 commits into from
Sep 19, 2024
Merged

Conversation

ilkilic
Copy link
Contributor

@ilkilic ilkilic commented Sep 16, 2024

No description provided.

@ilkilic ilkilic self-assigned this Sep 16, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 12.50000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 72.24%. Comparing base (4bfe32a) to head (57d2092).
Report is 35 commits behind head on master.

Files with missing lines Patch % Lines
bluepyefe/nwbreader.py 12.50% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #194      +/-   ##
==========================================
- Coverage   73.78%   72.24%   -1.55%     
==========================================
  Files          38       38              
  Lines        2415     2497      +82     
==========================================
+ Hits         1782     1804      +22     
- Misses        633      693      +60     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ilkilic ilkilic marked this pull request as ready for review September 18, 2024 08:05
Copy link
Collaborator

@AurelienJaquier AurelienJaquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Copy link
Contributor

@darshanmandge darshanmandge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. The reader works with one of the files with repetition entries under:
data['general']['intracellular_ephys']['intracellular_recordings']['repetition'].

@ilkilic ilkilic merged commit 88f089a into master Sep 19, 2024
4 checks passed
@ilkilic ilkilic deleted the scala-repetition branch September 19, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants