Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update unit tests #179

Merged
merged 1 commit into from
May 14, 2024
Merged

Update unit tests #179

merged 1 commit into from
May 14, 2024

Conversation

ilkilic
Copy link
Contributor

@ilkilic ilkilic commented May 8, 2024

No description provided.

@ilkilic ilkilic self-assigned this May 8, 2024
@ilkilic ilkilic requested a review from AurelienJaquier May 13, 2024 14:43
Copy link
Collaborator

@AurelienJaquier AurelienJaquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were those tests (before the change) not working?

@ilkilic
Copy link
Contributor Author

ilkilic commented May 13, 2024

The first test was working, I just changed it to an integer value to see if it would still work as expected. The second test was introduced after the change but before we decided to implement automatic type conversion

@ilkilic ilkilic merged commit d257166 into master May 14, 2024
4 checks passed
@ilkilic ilkilic deleted the fix-test branch May 14, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants