Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination to plot_recordings #172

Merged
merged 5 commits into from
Feb 2, 2024
Merged

Add pagination to plot_recordings #172

merged 5 commits into from
Feb 2, 2024

Conversation

ilkilic
Copy link
Contributor

@ilkilic ilkilic commented Feb 2, 2024

No description provided.

@ilkilic ilkilic self-assigned this Feb 2, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (master@87de1b6). Click here to learn what that means.

Files Patch % Lines
bluepyefe/cell.py 92.85% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #172   +/-   ##
=========================================
  Coverage          ?   74.05%           
=========================================
  Files             ?       38           
  Lines             ?     2390           
  Branches          ?        0           
=========================================
  Hits              ?     1770           
  Misses            ?      620           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@AurelienJaquier AurelienJaquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. If you have run this code on data and output figures are good, then you can merge

@ilkilic
Copy link
Contributor Author

ilkilic commented Feb 2, 2024

Thank you. I have run tests on two separate extraction and I can confirm that the figures have been plotted correctly

@ilkilic ilkilic merged commit eb83ba3 into master Feb 2, 2024
4 checks passed
@ilkilic ilkilic deleted the plot-pagination branch February 2, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants