Refactor 'amp' and 'hypamp' variables in Step for correct unit conversion #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #167 +/- ##
==========================================
+ Coverage 70.22% 70.41% +0.19%
==========================================
Files 35 35
Lines 2223 2221 -2
==========================================
+ Hits 1561 1564 +3
+ Misses 662 657 -5 ☔ View full report in Codecov by Sentry. |
bluepyefe/recording.py
Outdated
| if "amp" in reader_data: | ||
| amp = to_nA(reader_data["amp"], reader_data["i_unit"]) | ||
| if "hypamp" in reader_data: | ||
| hypamp = to_nA(reader_data["hypamp"], reader_data["i_unit"]) |
There was a problem hiding this comment.
I think there is also the possibility of having amp and hypamp in config_data. I would suggest checking for i_unit in config and amp in config, i_unit in config and amp in reader, i_unit in reader and amp in config, and i_unit in reader and amp in reader. So that we are sure of not missing any case.
|
added the unit conversion in 'set_amplitudes_ecode' |
AurelienJaquier
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.