Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new test for sAHP extraction #163

Merged
merged 7 commits into from
Dec 7, 2023

Conversation

AurelienJaquier
Copy link
Collaborator

Motivation: sAHP has two amplitudes, amp and amp2, which was not tested with current tests (only extracting for IDRest)

  • add init in tests folder so that we can fetch functions from other files, and exclude tests folder in setup find_packages, so that pypi does not make user download tests as a module, now that it has an init file in it.

@AurelienJaquier AurelienJaquier self-assigned this Dec 7, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d4edc58) 65.95% compared to head (d54e131) 70.22%.

Files Patch % Lines
tests/test_extractor.py 97.67% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #163      +/-   ##
==========================================
+ Coverage   65.95%   70.22%   +4.26%     
==========================================
  Files          34       35       +1     
  Lines        2159     2223      +64     
==========================================
+ Hits         1424     1561     +137     
+ Misses        735      662      -73     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ilkilic ilkilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, looks good!

@darshanmandge darshanmandge merged commit f46caab into BlueBrain:master Dec 7, 2023
4 checks passed
@AurelienJaquier AurelienJaquier deleted the BPE-amp2 branch December 8, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants