update efel deprecated functions calls

bluepyefe/extract.py

@@ -931,7 +931,8 @@ def extract_efeatures(
 
     if efel_settings is None:
         logger.warning(
-            "efel_settings is None. Default settings will be used"
+            "efel_settings is None. Default settings will be used: " +
+            str(DEFAULT_EFEL_SETTINGS)
         )
         efel_settings = DEFAULT_EFEL_SETTINGS.copy()
 

bluepyefe/tools.py

@@ -112,17 +112,7 @@ def set_efel_settings(efeature_settings):
         if setting in ['stim_start', 'stim_end']:
             value = float(value)
 
-        if setting == 'Threshold':
-            efel.setThreshold(value)
-
-        elif isinstance(value, bool) or isinstance(value, int):
-            efel.setIntSetting(setting, int(value))
-
-        elif isinstance(value, (float, list)):
-            efel.setDoubleSetting(setting, value)
-
-        elif isinstance(value, str):
-            efel.setStrSetting(setting, value)
+        efel.set_setting(setting, value)
 
 
 def dict_to_json(data, path):

tests/test_efel_settings.py

@@ -1,6 +1,7 @@
 """bluepyefe.cell tests"""
 
 import unittest
+import pytest
 
 import bluepyefe.cell
 import bluepyefe.recording
@@ -27,7 +28,7 @@ def setUp(self):
         )
 
     def test_efel_threshold(self):
-        
+
         self.cell.recordings[0].efeatures = {}
 
         self.cell.extract_efeatures(
@@ -69,6 +70,16 @@ def test_efel_threshold(self):
         recording = self.cell.recordings[0]
         self.assertEqual(recording.efeatures["Spikecount"], 0.)
 
+    def test_efel_incorrect_threshold(self):
+
+        self.cell.recordings[0].efeatures = {}
+
+        with pytest.raises(ValueError):
+            self.cell.extract_efeatures(
+                protocol_name="IDRest",
+                efeatures=["Spikecount"],
+                efel_settings={'Threshold': "40."}
+            )
 
 if __name__ == "__main__":
     unittest.main()