signer: Increase the feerate for commitment TXs and warn on failure #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should get the couple of nodes that are stuck on a large commitment TX fee unstuck. We triple the feerate in order to not run into the deadlock, and we make the policy failure a warning instead. Once VLS reimplements the per-payment fee budget we should be able to tighten these again.
cdecker
force-pushed
the
202451-fee-range-bump
branch
from
43f8fb3 to
9214996
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should get the couple of nodes that are stuck on a large
commitment TX fee unstuck. We triple the feerate in order to not run
into the deadlock, and we make the policy failure a warning instead.
This is not a solution to #538, since it is just a one-time adjustment. Ideally we'd have an independent feerate oracle that VLS can query independently.