Some CLI improvements #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice improvements, just one more idea for a further improvement down the line. |
|
And pressing Shift while commenting closes the PR, my bad |
Signed-off-by: Peter Neuroth <[email protected]>
As we do not show bip39 mnenomics at the moment, there is no need to go the way through a mnemonic Signed-off-by: Peter Neuroth <[email protected]>
Signed-off-by: Peter Neuroth <[email protected]>
A flush is not needed here as `File` utilizes Os memory (afaict) which will write to the fs once we drop the `File`. We still a manual `sync_all()` to catch any errors that could arise writing to the fs that we would miss if we just drop the `File`. Signed-off-by: Peter Neuroth <[email protected]>
cdecker
force-pushed
the
2442-glcli-additions
branch
from
b0ce0e4 to
065cc36
Compare
cdecker
reviewed
Oct 22, 2024
Comment on lines
+62
to
+63
| .map(|d| util::DataDir(PathBuf::from_str(&d).expect("is not a valid path"))) | ||
| .unwrap_or_default(); |
There was a problem hiding this comment.
Would a combination of .flatten() and emitting a Result<> in the .map() be an alternative to prevent panicking inside of a closure? My main concern is that this error might not be a rare one, and we might want insightful error messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses some of the improvements suggested in #515.