Linting

Makefile

@@ -0,0 +1,4 @@
+.PHONY: lint
+lint:
+	golangci-lint run --enable gofmt ./...
+

pkg/docker/docker.go

@@ -387,7 +387,7 @@ func (bm *BasicManager) createContainer(ctx context.Context, container Container
 	var mounts []mount.Mount
 	for _, mountParam := range container.Mounts {
 
-		from := mountParam.From
+		from := ""
 		if mountParam.Type == "bind" {
 			from = bm.addBasePath(mountParam.From)
 		} else { // volume

pkg/node/node.go

@@ -6,13 +6,13 @@
 package node
 
 import (
-	"strings"
 	"encoding/json"
 	"fmt"
 	"io/ioutil"
-	"path"
 	"os"
+	"path"
 	"path/filepath"
+	"strings"
 
 	"github.com/Blockdaemon/bpm-sdk/internal/util"
 	homedir "github.com/mitchellh/go-homedir"
@@ -119,7 +119,7 @@ func (c Node) Save() error {
 }
 
 func New(nodeFile string) Node {
-	return Node{ nodeFile: nodeFile }
+	return Node{nodeFile: nodeFile}
 }
 
 // Load all the data for a particular node and creates all required directories
@@ -185,4 +185,3 @@ func Load(nodeFile string) (Node, error) {
 
 	return node, nil
 }
-

pkg/plugin/docker.go

@@ -84,12 +84,12 @@ func (d DockerPlugin) ValidateParameters(currentNode node.Node) error {
 
 		if parameter.Type == ParameterTypeBool {
 			_, ok = currentNode.BoolParameters[parameter.Name]
-		} 
+		}
 
 		if parameter.Type == ParameterTypeString {
 			_, ok = currentNode.StrParameters[parameter.Name]
 
-		} 
+		}
 
 		if !ok {
 			return fmt.Errorf(`%q missing`, parameter.Name)
@@ -110,7 +110,7 @@ func (d DockerPlugin) CreateSecrets(currentNode node.Node) error {
 
 // The default upgrade strategy removes all containers. If they where running they get started again which will pull new container images.
 //
-// This works as long as only the container version changes. If the the upgrade needs changes to the configs or migrations tasks it is 
+// This works as long as only the container version changes. If the the upgrade needs changes to the configs or migrations tasks it is
 // recommended to overwrite this function
 func (d DockerPlugin) Upgrade(currentNode node.Node) error {
 	status, err := d.Status(currentNode)

pkg/plugin/meta.go

@@ -8,7 +8,7 @@ const (
 	ParameterTypeBool   = "bool"
 	ParameterTypeString = "string"
 
-	SupportsTest        = "test"
+	SupportsTest = "test"
 )
 
 type Parameter struct {
@@ -20,11 +20,11 @@ type Parameter struct {
 }
 
 type MetaInfo struct {
-	Version               string
-	Description           string
+	Version         string
+	Description     string
 	ProtocolVersion string `yaml:"protocol_version"`
-	Parameters            []Parameter
-	Supported             []string
+	Parameters      []Parameter
+	Supported       []string
 }
 
 func (p MetaInfo) String() string {