Add CypherpunkPay. #31
Conversation
|
@icculp If you have time, please could you review this? |
nochiel
force-pushed
the
cypherpunkpay
branch
2 times, most recently
from
0c3117a
to
37745eb
Compare
|
Haven't run yet but so far reviewing code changes, both scripts look like they're looking for Debian release for Tor setup and CLI tutorial indicates Debian, as well as scripts README indicates Debian for at least LinodeStandup.sh. The cypherpunk setup you added is adding source for ubuntu focal. Can multiple OSes be added to the source list so the script runs on either platform? Also, it looks like cypherpunk source is limited to Debian 10 so would need a note at least indicating this addon isn't supported on Debian 9. Opened issue #32 regarding tor setup to test on Ubuntu |
Scripts/LinodeStandUp.sh
Outdated
| @@ -62,6 +62,10 @@ | |||
| # SYS_SSH_IP= | |||
| # <UDF name="region" label="Timezone" oneOf="Asia/Singapore,America/Los_Angeles" default="America/Los_Angeles" example="Servers location" optional="false"/> | |||
| # REGION= | |||
| # <UDF name="cypherpunkPay" label="Install CypherPunkPay" oneOf="YES,NO" default="NO" optional="true"/> | |||
| # USE_CYPHERPUNKPAY= | |||
| # <UDF name="xpub" label="XPUB from your new CypherpunkPay wallet" default="" example="xpub5SLqN2bLY4WeYfrqh3V99Wn5UF7wqQhuSAnCnycZd8viZ1SHV4ABrG2joGZrezpR" optional="true"/> | |||
There was a problem hiding this comment.
In the example tag maybe add clarification, an end user not familiar might wonder if they should be using that address as a default or if you're just showing an example of what one looks like.
There was a problem hiding this comment.
I see that's similar to the example for the tor pub key. Maybe a link on yours to reference the wallet reqs
ex: xpub5SLqN2bLY4WeYfrqh3V99Wn5UF7wqQhuSAnCnycZd8viZ1SHV4ABrG2joGZrezpR
See https://cypherpunkpay.org/installation/bitcoin-wallet/ for additional information
I wonder if multiple lines can be added like that. If so we could add a note to the tor pubkey example too
There was a problem hiding this comment.
Additionally, looks like it can be xpub or zpub, so maybe rename to XPUB/ZPUB. I'm testing with electrum and the master public key is a zpub, and the cypherpunkpay website says can be either.
nochiel
force-pushed
the
cypherpunkpay
branch
from
cdf5d92
to
9046e62
Compare
nochiel
force-pushed
the
cypherpunkpay
branch
from
9046e62
to
362a53f
Compare
|
Committing to Debian 10 is not necessarily a bad thing. Debian 9 is pretty long-in-the-tooth. (Will look in more depth at everything soon.) |
|
I've in fact pushed the scripts over to Debian 11 as their default, so the versioning should be fine. Apologies for this sitting for a bit, I was doing other updates. I'm now looking over this, with the hope of fully integrating it next week. |
|
(That merge was to support changes to Tor ports for bitcoin services, per Peter. ) |
Guessing this may have been causing problems with cyerpunkpay_cause going out of place and being marked mandatory?
|
Thank you @shannona. I'm grateful for the review and for improving the script. That typo must have slipped in after I tested on Linode, while working in Docker. |
and reverted the label on cypherpunkpay_lite (still looking for why cypherpunkpay_cause is not showing up right in Linode creation script.
|
Sure thing! Just a few more iterations and we should be able to merge. |
We apparently do need a label or we just get an unlabeled "YES/NO".
needed the installation of cyperpunkpay to be a bit less quiet
(Matching Stackscript changes)
= -> ==
|
Testing of Stackscript with cypherpunkpay turned off: works fine (that's the default setup). However I haven't yet gotten it to successfully install cypherpunkpay, apparently because the USE_CYPHERPUNKPAY variable isn't coming through? I need to investigate that more and will continue in the morning. |
|
Testing now successful on both Linode & script with cypherpunkpay both on and off. |
|
Thanks, @nochiel ! |
No description provided.