Make full validation result details available (also per field)

[luetm]

It looks like this was once possible (see #75 ). I think the simplest way to add this is to just make the ValidationFailures available, so if anyone needs anything else from it (not just Severity) they can.

The approach is easy, I just save the latest validation run for a FluentValidationValidator and made a method to easily access it (GetFailuresFromLastValidation).

I tried to follow the style as well as I could, and I added a documentation paragraph about it, which I can remove if that's not desired.

Closes #75

[chrissainty]

Thanks @luetm this looks good to me. If you wanted bonus points it would be great to add some tests--it's been on my todo for far too long. 😉

[luetm]

Sure, I'll look into it!

[Liero]

@luetm : I just had a chance to look at the PR only now and would suggest to store the last FluentValidation's ValidationResult in EditContext instead UI component.

EditContext.Properties are made exactly for such cases

The reason is that EditContext can be used in component-free UI layer like ViewModels. I wouldn't recommend to keep reference to FluentValidator component in a viewmodel.

Also lifetime of EditContext might be different than UI Components. I used EditContext like this:

class ViewModel 
{
     public ViewModel()
     {
         EditContext = new EditContext(this);
         //subscribe for EditContext's events, maybe perform initial validation, etc...
     }
     
     public EditContext EditContext {get;}
}

<EditForm Context="_viewModel.EditContext">

I also recommend you to add option to format different severity levels differently. Without it, the UX will be quite poor.
For example add [Warning] prefix

[luetm]

@Liero OK, should I do a PR that undoes this PR and implements it in the other way? I like the idea!
Edit: Is there a discord or another community hub we can discuss this?

[Liero]

@luetm: Not my choice, I am not even contributor here. I made my own fluentvalidator long time ago, since I needed special features back then, but I'm happy they are being ported here. I'm just sharing my own experience

[luetm]

@Liero I'm not sure what you mean by this

I also recommend you to add option to format different severity levels differently. Without it, the UX will be quite poor.
For example add [Warning] prefix

Can you explain further please?

[chrissainty]

@Liero would you be able to create an issue covering the points you made?

@luetm If Liero can do that you could raise a PR against that new issue.

[Liero]

@chrissainty:

I'm not sure what you mean by this
For example, try to display warnings with orange text color so that user knows it is a warning.

Check demo and source code: https://github.com/Liero/vNext.BlazorComponents.FluentValidation
Feel free to use it.

It's OT, but if I may: I think the entire EditContextExtensions class lost it's point.

It only makes sense when it its independent of the FluentValidator UI component, but that is not the case here. The original extension allowed to add fluent validations without FluentValidator component.

Either create something like FluentValidatorOptions property that would be a parameter to EditContextExtensions, or move all the code to FluentValidator UI component.

I'm mentioning FluentValidatorOptions because it is also a good way of accessing last ValidationFailure or asynchronous Task<ValidationFailure> that can be awaited