Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples and more tests #46

Merged
merged 8 commits into from
Nov 6, 2023
Merged

Add examples and more tests #46

merged 8 commits into from
Nov 6, 2023

Conversation

sivonxay
Copy link
Member

@sivonxay sivonxay commented Nov 6, 2023

  • Fix issue when initializing a nanoparticle from dict, when the nanoparticle has previously had its hosts pruned to only 'Y'.

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #46 (46b0bd6) into main (5521c45) will increase coverage by 4.71%.
The diff coverage is 59.52%.

@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
+ Coverage   80.45%   85.16%   +4.71%     
==========================================
  Files          43       43              
  Lines        3479     3499      +20     
==========================================
+ Hits         2799     2980     +181     
+ Misses        680      519     -161     
Files Coverage Δ
.../NanoParticleTools/differential_kinetics/runner.py 100.00% <ø> (ø)
...rc/NanoParticleTools/differential_kinetics/util.py 100.00% <ø> (ø)
src/NanoParticleTools/inputs/nanoparticle.py 91.25% <83.33%> (-0.47%) ⬇️
.../NanoParticleTools/analysis/simulation_replayer.py 96.51% <72.22%> (+82.83%) ⬆️
src/NanoParticleTools/flows/jobs.py 16.83% <16.66%> (+0.50%) ⬆️

... and 2 files with indirect coverage changes

@sivonxay
Copy link
Member Author

sivonxay commented Nov 6, 2023

Since we are introducing tests for previously untested files, we can ignore the failed check

@sivonxay sivonxay merged commit f81a604 into main Nov 6, 2023
5 of 6 checks passed
@sivonxay sivonxay deleted the tests branch November 6, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant