Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyperboloidal #14

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Hyperboloidal #14

wants to merge 13 commits into from

Conversation

dohertycw
Copy link
Collaborator

Addition of Hyperboloidal Method for circular orbits. Access this using Method -> "Hyperboloidal" in ReggeWheelerPointParticleMode[ ].

dohertycw and others added 8 commits December 16, 2024 14:51
…e fluxes work correctly by introducing a Method key in the ReggeWheelerMode association
…cess it via ReggeWheelerPointParticleMode with a Method->"Hyperboloidal". You can also pass options to the hyperboloidal method via, e.g., Method -> {"Hyperboloidal", "GridPoints" -> 40}
…erMode package, removal of unnecessary xi function in ReggeWheelerHyperboloidal, Hyperboloidal method "Radial Function" (name will be changed) key correctly returns solution in t-slicing, removal of unnecessary construction of ReggeWheelerHyperboloidalMode object and related associations and replaced with a call to the existing ReggeWheelerMode object, "WorkingPrecision" option for ReggeWheelerHyperboloidal removed, working precision now based on user specified orbital radius.
@nielsw2
Copy link
Member

nielsw2 commented Dec 18, 2024

You can also change the number of grid points using the option:

mode = ReggeWheelerPointParticleMode[2, 2, 2, 0, orbit, Method -> {"Hyperboloidal", "GridPoints" -> 32}]

Things that still need to be done:

  • Add analytic mesh refinement
  • Static modes are implemented (we change this to provide an error message for now).
  • Add Documentation (we need to update the documentation for the entire package to the new system)
  • Get the output to agree with the rest of the package (this is changing as @joshbmat is changing to output RW and Zerilli-Moncrief as part of the eccentric orbit work).

@nielsw2 nielsw2 requested a review from joshbmat December 18, 2024 12:15
@nielsw2
Copy link
Member

nielsw2 commented Dec 18, 2024

Also, unit tests, but I suspect we need those across the package.

@nielsw2
Copy link
Member

nielsw2 commented Dec 18, 2024

And we also need to copy the code from the Teukolsky package that allows you to evaluate a PointParticleMode at a given radius (and allows on the worldline/within the libration region if the ExtendedHomogeneous option is passed).

@nielsw2 nielsw2 requested a review from bleather December 18, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants