Backwards integration #104
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
June 1, 2023 00:05
added 21 commits
June 7, 2023 16:23
Spline interpolation was not working at all with MCMC. Instead I am now modifying the phases and letting it properly integrate backwards. The resultant waveform appears as if it were integrated forwards in time. There is a small bug though, there is a slight phase shift between the forwards integrated and backwards integrated waveform. Need to fix this later. Just something to be aware of.
There is an annoying bug I cannot spot. The waveform seems like it has a constant phase shift and I can't identify this right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backwards integration scheme for FEW. Change inspiral keyword arguments: integrate_backwards: True to allow for trajectories in reverse.
Feed in final parameters defined at p_f, e_f, iota_f (such that p_f > p_sep) and evolve backwards for T years. Final parameters p0, e0, iota0 will be found as last point in trajectory.
Unittests are also incorporated.