Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signuperror : sign up toast error solved #338 done #345

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

VinayLodhi1712
Copy link
Contributor

Title and Issue number

Title: Signuperror : sign up toast error solved #338 done

Issue No.:

Close #338


Screenshots/Video (mandatory)

20241102152002.mp4

Checklist:

  • [ X] I have mentioned the issue number in my Pull Request.
  • [X ] I have commented my code, particularly in hard-to-understand areas.
  • [ X] I have created a helpful and easy-to-understand README.md if it's a new page/tech stack.
  • [ X] I have gone through the contributing.md file before contributing.

Additional context (Mandatory):

Are you contributing under any Open-source programme?

  • [x ] I'm a GSSOC-EXT contributor
  • [ X] I'm a HACKTOBERFEST contributor

Copy link

netlify bot commented Nov 2, 2024

👷 Deploy request for bitbox-in accepted.

Name Link
🔨 Latest commit ee7b491
🔍 Latest deploy log https://app.netlify.com/sites/bitbox-in/deploys/6725f99b2afe5000095f0aa9

Copy link

github-actions bot commented Nov 2, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our chaotic CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@Anuj3553
Copy link
Collaborator

Anuj3553 commented Nov 2, 2024

Here is the issue I don't want to login directly thats why i give the error response. Only if the user verification is complete by email then it can login through login

@Anuj3553
Copy link
Collaborator

Anuj3553 commented Nov 2, 2024

If you can figured out the way then it is very good

@VinayLodhi1712
Copy link
Contributor Author

can we redirect user to the login page..? He has to put the credentials in the input box then only he can login.

@Anuj3553
Copy link
Collaborator

Anuj3553 commented Nov 4, 2024

can we redirect user to the login page..? He has to put the credentials in the input box then only he can login.

Yes you can but here is some suggestion that you can modify the alert in frontend not on the backend side.

@VinayLodhi1712
Copy link
Contributor Author

VinayLodhi1712 commented Nov 4, 2024

What suggestions you want i have to keep in mind @Anuj3553 ...?

@Anuj3553
Copy link
Collaborator

Anuj3553 commented Nov 5, 2024

What suggestions you want i have to keep in mind @Anuj3553 ...?

You can navigate to login page but keep in mind we have to verify first from mail and only then we can able to login.

@VinayLodhi1712
Copy link
Contributor Author

What suggestions you want i have to keep in mind @Anuj3553 ...?

You can navigate to login page but keep in mind we have to verify first from mail and only then we can able to login.

then we have to check in backend with creating a variable in models of user whether user is verified or not. Because i think currently also without verifying also login will be done with id and password.

@Anuj3553
Copy link
Collaborator

Anuj3553 commented Nov 6, 2024

What suggestions you want i have to keep in mind @Anuj3553 ...?

You can navigate to login page but keep in mind we have to verify first from mail and only then we can able to login.

then we have to check in backend with creating a variable in models of user whether user is verified or not. Because i think currently also without verifying also login will be done with id and password.

Yes, its correct

@VinayLodhi1712
Copy link
Contributor Author

ok i will try to do it and when it done then i will create a pr but since now i have to work on the backend side and also checking the email and verification and then send message to frontend so i need time and also it becomes an level 3 issue so if i can do it successfully the its request that you plz increase the level of it.

@Anuj3553
Copy link
Collaborator

Anuj3553 commented Nov 6, 2024

ok i will try to do it and when it done then i will create a pr but since now i have to work on the backend side and also checking the email and verification and then send message to frontend so i need time and also it becomes an level 3 issue so if i can do it successfully the its request that you plz increase the level of it.

Definately i will increase your level from current to level3 ✌️.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants